lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 545/663] crypto: sun4i-ss - checking sg length is not sufficient
    Date
    From: Corentin Labbe <clabbe@baylibre.com>

    commit 7bdcd851fa7eb66e8922aa7f6cba9e2f2427a7cf upstream.

    The optimized cipher function need length multiple of 4 bytes.
    But it get sometimes odd length.
    This is due to SG data could be stored with an offset.

    So the fix is to check also if the offset is aligned with 4 bytes.
    Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
    +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
    @@ -201,12 +201,12 @@ static int sun4i_ss_cipher_poll(struct s
    * we can use the SS optimized function
    */
    while (in_sg && no_chunk == 1) {
    - if (in_sg->length % 4)
    + if ((in_sg->length | in_sg->offset) & 3u)
    no_chunk = 0;
    in_sg = sg_next(in_sg);
    }
    while (out_sg && no_chunk == 1) {
    - if (out_sg->length % 4)
    + if ((out_sg->length | out_sg->offset) & 3u)
    no_chunk = 0;
    out_sg = sg_next(out_sg);
    }

    \
     
     \ /
      Last update: 2021-03-02 01:11    [W:4.217 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site