lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 235/663] drm/lima: fix reference leak in lima_pm_busy
    Date
    From: Qinglang Miao <miaoqinglang@huawei.com>

    [ Upstream commit de4248b744e8394f239c0dd0af34088399d27d94 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to putting operation will result in a
    reference leak here.

    A new function pm_runtime_resume_and_get is introduced in
    [0] to keep usage counter balanced. So We fix the reference
    leak by replacing it with new function.

    [0] commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")

    Fixes: 50de2e9ebbc0 ("drm/lima: enable runtime pm")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
    Signed-off-by: Qiang Yu <yuq825@gmail.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201127094438.121003-1-miaoqinglang@huawei.com
    (cherry picked from commit de499781c97d96703af8a32d2b5e37fdb5b51568)
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/lima/lima_sched.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
    index dc6df9e9a40d8..f6e7a88a56f1b 100644
    --- a/drivers/gpu/drm/lima/lima_sched.c
    +++ b/drivers/gpu/drm/lima/lima_sched.c
    @@ -200,7 +200,7 @@ static int lima_pm_busy(struct lima_device *ldev)
    int ret;

    /* resume GPU if it has been suspended by runtime PM */
    - ret = pm_runtime_get_sync(ldev->dev);
    + ret = pm_runtime_resume_and_get(ldev->dev);
    if (ret < 0)
    return ret;

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 01:11    [W:3.336 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site