lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 002/775] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()
    Date
    From: Stefano Garzarella <sgarzare@redhat.com>

    commit dcfde1635e764fd69cc756c7780d144e288608e9 upstream.

    It's legal to have 'offset + len' equal to
    sizeof(struct virtio_net_config), since 'ndev->config' is a
    'struct virtio_net_config', so we can safely copy its content under
    this condition.

    Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
    Cc: stable@vger.kernel.org
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    Link: https://lore.kernel.org/r/20210208161741.104939-1-sgarzare@redhat.com
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Acked-by: Eli Cohen <elic@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
    +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
    @@ -1820,7 +1820,7 @@ static void mlx5_vdpa_get_config(struct
    struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
    struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);

    - if (offset + len < sizeof(struct virtio_net_config))
    + if (offset + len <= sizeof(struct virtio_net_config))
    memcpy(buf, (u8 *)&ndev->config + offset, len);
    }


    \
     
     \ /
      Last update: 2021-03-02 00:42    [W:4.042 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site