lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Sv: Sv: [PATCH] hrtimer: Interrupt storm on clock_settime
Date
Micke,

On Thu, Feb 25 2021 at 12:18, Mikael Beckius wrote:

>> The proposed change breaks the reprogramming logic. To keep it working
>> cpu_base::*expires_next is only updated by hrtimer_reprogram() and
>> hrtimer_interrupt(). I will send you a patch for testing in reply to this
>> thread. The patch is compile tested only.
>>
> Ok. I kind of guessed that would be the response as I noticed a similar comment
> during the review of the original patch which introduced the softirq_expires_next
> logic. Anyway it seemed logical to update softirq_expires_next
> when updating softirq_next_timer.

yes it seems logical to do that, but unfortunately the logic there is a
bit twisted and could do with some deobfuscation.

Thanks,

tglx

\
 
 \ /
  Last update: 2021-03-01 10:17    [W:0.112 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site