lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 118/340] ima: Free IMA measurement buffer on error
    Date
    From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>

    [ Upstream commit 6d14c6517885fa68524238787420511b87d671df ]

    IMA allocates kernel virtual memory to carry forward the measurement
    list, from the current kernel to the next kernel on kexec system call,
    in ima_add_kexec_buffer() function. In error code paths this memory
    is not freed resulting in memory leak.

    Free the memory allocated for the IMA measurement list in
    the error code paths in ima_add_kexec_buffer() function.

    Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
    Suggested-by: Tyler Hicks <tyhicks@linux.microsoft.com>
    Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list")
    Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    security/integrity/ima/ima_kexec.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
    index 9e94eca48b898..37b1244e3a166 100644
    --- a/security/integrity/ima/ima_kexec.c
    +++ b/security/integrity/ima/ima_kexec.c
    @@ -120,6 +120,7 @@ void ima_add_kexec_buffer(struct kimage *image)
    ret = kexec_add_buffer(&kbuf);
    if (ret) {
    pr_err("Error passing over kexec measurement buffer.\n");
    + vfree(kexec_buffer);
    return;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 23:21    [W:2.116 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site