lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 070/340] fbdev: aty: SPARC64 requires FB_ATY_CT
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit c6c90c70db4d9a0989111d6b994d545659410f7a ]

    It looks like SPARC64 requires FB_ATY_CT to build without errors,
    so have FB_ATY select FB_ATY_CT if both SPARC64 and PCI are enabled
    instead of using "default y if SPARC64 && PCI", which is not strong
    enough to prevent build errors.

    As it currently is, FB_ATY_CT can be disabled, resulting in build
    errors:

    ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
    ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!

    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: sparclinux@vger.kernel.org
    Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Cc: dri-devel@lists.freedesktop.org
    Cc: linux-fbdev@vger.kernel.org
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201127031752.10371-1-rdunlap@infradead.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
    index 1e70e838530ee..a7e5f12687b70 100644
    --- a/drivers/video/fbdev/Kconfig
    +++ b/drivers/video/fbdev/Kconfig
    @@ -1269,6 +1269,7 @@ config FB_ATY
    select FB_CFB_IMAGEBLIT
    select FB_BACKLIGHT if FB_ATY_BACKLIGHT
    select FB_MACMODES if PPC
    + select FB_ATY_CT if SPARC64 && PCI
    help
    This driver supports graphics boards with the ATI Mach64 chips.
    Say Y if you have such a graphics board.
    @@ -1279,7 +1280,6 @@ config FB_ATY
    config FB_ATY_CT
    bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
    depends on PCI && FB_ATY
    - default y if SPARC64 && PCI
    help
    Say Y here to support use of ATI's 64-bit Rage boards (or other
    boards based on the Mach64 CT, VT, GT, and LT chipsets) as a
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 23:12    [W:4.491 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site