lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 242/247] xfrm: interface: use icmp_ndo_send helper
    Date
    From: Jason A. Donenfeld <Jason@zx2c4.com>

    commit 45942ba890e6f35232727a5fa33d732681f4eb9f upstream.

    Because xfrmi is calling icmp from network device context, it should use
    the ndo helper so that the rate limiting applies correctly.

    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Cc: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/xfrm/xfrm_interface.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/net/xfrm/xfrm_interface.c
    +++ b/net/xfrm/xfrm_interface.c
    @@ -300,10 +300,10 @@ xfrmi_xmit2(struct sk_buff *skb, struct
    if (mtu < IPV6_MIN_MTU)
    mtu = IPV6_MIN_MTU;

    - icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
    + icmpv6_ndo_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
    } else {
    - icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
    - htonl(mtu));
    + icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
    + htonl(mtu));
    }

    dst_release(dst);

    \
     
     \ /
      Last update: 2021-03-01 22:45    [W:4.260 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site