lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 013/340] ath10k: Fix error handling in case of CE pipe init failure
    Date
    From: Rakesh Pillai <pillair@codeaurora.org>

    [ Upstream commit 31561e8557cd1eeba5806ac9ce820f8323b2201b ]

    Currently if the copy engine pipe init fails for snoc based
    chipsets, the rri is not freed.

    Fix this error handling for copy engine pipe init
    failure.

    Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

    Fixes: 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")
    Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
    Reviewed-by: Brian Norris <briannorris@chromium.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/1607713210-18320-1-git-send-email-pillair@codeaurora.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/snoc.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
    index 63607c3b8e818..d4589b2ab3b6d 100644
    --- a/drivers/net/wireless/ath/ath10k/snoc.c
    +++ b/drivers/net/wireless/ath/ath10k/snoc.c
    @@ -1039,12 +1039,13 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar,
    ret = ath10k_snoc_init_pipes(ar);
    if (ret) {
    ath10k_err(ar, "failed to initialize CE: %d\n", ret);
    - goto err_wlan_enable;
    + goto err_free_rri;
    }

    return 0;

    -err_wlan_enable:
    +err_free_rri:
    + ath10k_ce_free_rri(ar);
    ath10k_snoc_wlan_disable(ar);

    return ret;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 22:41    [W:5.395 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site