lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
On Fri, Feb 26, 2021 at 02:16:12PM -0700, Shuah Khan wrote:
> On 2/26/21 2:07 PM, Peter Zijlstra wrote:
> > On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote:
> > > + /* avoid false negative lockdep_assert_not_held()
> > > + * and lockdep_assert_held()
> > > + */
> >
> > That's a coding style fail.
> >
>
> Checkpatch didn't complain.

Documentation/CodingStyle

(or whatever unreadable rst crap it is today :-( )

and:

https://lkml.kernel.org/lkml/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com/

> What's your preference? Does the following work for you?
>
> /*
> * avoid false negative lockdep_assert_not_held()
> * and lockdep_assert_held()
> */

Yep (ideally even with a Capital and full stop).

\
 
 \ /
  Last update: 2021-03-01 09:30    [W:0.513 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site