lkml.org 
[lkml]   [2021]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] checkpatch: do not apply "initialise globals to 0" check to BPF progs
Date


> On Feb 8, 2021, at 10:29 PM, Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2021-02-08 at 15:40 -0800, Song Liu wrote:
>> BPF programs explicitly initialise global variables to 0 to make sure
>> clang (v10 or older) do not put the variables in the common section.
>> Skip "initialise globals to 0" check for BPF programs to elimiate error
>> messages like:
>>
>> ERROR: do not initialise globals to 0
>> #19: FILE: samples/bpf/tracex1_kern.c:21:
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -4323,7 +4323,11 @@ sub process {
>> }
>>
>>
>> # check for global initialisers.
>> - if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/) {
>> +# Do not apply to BPF programs (tools/testing/selftests/bpf/progs/*.c, samples/bpf/*_kern.c, *.bpf.c).
>> + if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/ &&
>> + $realfile !~ /^tools\/testing\/selftests\/bpf\/progs\/.*\.c/ &&
>> + $realfile !~ /^samples\/bpf\/.*_kern.c/ &&
>> + $realfile !~ /.bpf.c$/) {
>
> probably better to make this a function so when additional files are
> added it'd be easier to update this and it will not look as complex.
>
> if ($line =~ /.../ &&
> !exclude_global_initialisers($realfile))

Good point! I will make this a function in v2.

--ignore is not ideal, because it is common for a BPF test/sample patch
to have both BPF code and user space code. Adding --ignore will skip the
check for user space code.

Thanks,
Song


\
 
 \ /
  Last update: 2021-02-09 17:51    [W:0.041 / U:3.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site