Messages in this thread | | | From | Guo Ren <> | Date | Wed, 10 Feb 2021 00:02:57 +0800 | Subject | Re: [PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610 |
| |
Hi Daniel,
On Sun, Feb 7, 2021 at 5:29 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On 07/02/2021 04:31, Guo Ren wrote: > > Hi Daniel, > > > > On Thu, Feb 4, 2021 at 4:48 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > >> > >> On 04/02/2021 08:46, guoren@kernel.org wrote: > >>> From: Guo Ren <guoren@linux.alibaba.com> > >>> > >>> The timer-mp-csky.c only could support CPU_CK860 and it will > >>> compile error with CPU_CK610. > >>> > >>> It has been selected in arch/csky/Kconfig. > >> > >> It would be better if you fix the root cause of the compilation error. > > The timer-mp-csky.c has used specific instructions which only > > supported by CK860 and timer-mp-csky.c is only design for CK860. > > I guess you are referring to mfcr() ? > > > In arch/csky/Konfig we only select it with CK860. > > select CSKY_MPINTC if CPU_CK860 > > select CSKY_MP_TIMER if CPU_CK860 > > > > So here let's select timer-mp-csky.c in arch/csky/Kconfig, not in > > drivers/clocksource/Kconfig. > > The COMPILE_TEST option is there to let other architecture to compile > drivers and increase the compilation test coverage. > > The proposed change just removes the driver from this coverage. When we compile the csky arch with C860, it will be selected.
> > Ideally, it would be better to keep it with the COMPILE_TEST option, so > changes impacting all the drivers can be caught before submitting the > patches. > > By just adding > > #ifndef mfcr > #define mfcr(a) 0 > #endif
610 couldn't support CSKY_MP_TIMER and it's only for 860. So it's not a coding skill issue.
-- Best Regards Guo Ren
ML: https://lore.kernel.org/linux-csky/
| |