lkml.org 
[lkml]   [2021]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint
    On Tue, Feb 09, 2021 at 09:46:35AM -0800, Yang Shi wrote:
    > The tracepoint's nid should show what node the shrink happens on, the start tracepoint
    > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the
    > shrinker is not NUMA aware, so the traceing log may show the shrink happens on one
    > node but end up on the other node. It seems confusing. And the following patch
    > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup
    > the code.
    >
    > Acked-by: Vlastimil Babka <vbabka@suse.cz>
    > Acked-by: Kirill Tkhai <ktkhai@virtuozzo.com>
    > Signed-off-by: Yang Shi <shy828301@gmail.com>

    Acked-by: Roman Gushchin <guro@fb.com>

    > ---
    > mm/vmscan.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/vmscan.c b/mm/vmscan.c
    > index b1b574ad199d..b512dd5e3a1c 100644
    > --- a/mm/vmscan.c
    > +++ b/mm/vmscan.c
    > @@ -535,7 +535,7 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl,
    > else
    > new_nr = atomic_long_read(&shrinker->nr_deferred[nid]);
    >
    > - trace_mm_shrink_slab_end(shrinker, nid, freed, nr, new_nr, total_scan);
    > + trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, total_scan);
    > return freed;
    > }
    >
    > --
    > 2.26.2
    >

    \
     
     \ /
      Last update: 2021-02-10 02:35    [W:2.737 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site