lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 25/43] USB: gadget: legacy: fix an error code in eth_bind()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 3e1f4a2e1184ae6ad7f4caf682ced9554141a0f4 upstream.

    This code should return -ENOMEM if the allocation fails but it currently
    returns success.

    Fixes: 9b95236eebdb ("usb: gadget: ether: allocate and init otg descriptor by otg capabilities")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/YBKE9rqVuJEOUWpW@mwanda
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/legacy/ether.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/gadget/legacy/ether.c
    +++ b/drivers/usb/gadget/legacy/ether.c
    @@ -407,8 +407,10 @@ static int eth_bind(struct usb_composite
    struct usb_descriptor_header *usb_desc;

    usb_desc = usb_otg_descriptor_alloc(gadget);
    - if (!usb_desc)
    + if (!usb_desc) {
    + status = -ENOMEM;
    goto fail1;
    + }
    usb_otg_descriptor_init(gadget, usb_desc);
    otg_desc[0] = usb_desc;
    otg_desc[1] = NULL;

    \
     
     \ /
      Last update: 2021-02-08 16:51    [W:21.441 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site