lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci: add Silicom Denmark vendor id
Hi Martin,

Thank you for sending the patch over!

A few suggestions. Try to keep the patch style aligned with previous
submissions, see the following for to format the subject line, etc.,
a few examples:

$ git log --oneline include/linux/pci_ids.h | grep -E 'Add.*ID' | head -n 10
8b7beaf9f185 PCI: Add Intel QuickAssist device IDs
a4e91825d7e1 x86/amd_nb: Add AMD family 17h model 60h PCI IDs
3375590623e4 PCI: Add Zhaoxin Vendor ID
9acb9fe18d86 PCI: Add Loongson vendor ID
b3f79ae45904 x86/amd_nb: Add Family 19h PCI IDs
4a36a60c34f4 PCI: Add Amazon's Annapurna Labs vendor ID
4460d68f0b2f PCI: Add Genesys Logic, Inc. Vendor ID
af4e1c5eca95 x86/amd_nb: Add PCI device IDs for family 17h, model 70h
1f418f46503d PCI: Add Synopsys endpoint EDDA Device ID
b8580e9de48b PCI: Add HXT vendor ID

If you have a moment, see [1] which you can use as a guide for patches
submissions against the PCI sub-system.

[...]
> Update pci_ids.h with the vendor id for Silicom Denmark.

It would be "ID" here.

[...
> +#define PCI_VENDOR_ID_SILICOM_DENMARK 0x1c2c

Are they any drivers for this new device already?

1. https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/

Krzysztof

\
 
 \ /
  Last update: 2021-02-08 15:59    [W:0.062 / U:2.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site