lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] kdb: Refactor env variables get/set code
Hi Daniel,

On Fri, 5 Feb 2021 at 23:06, Daniel Thompson <daniel.thompson@linaro.org> wrote:
>
> On Thu, Feb 04, 2021 at 03:44:20PM +0530, Sumit Garg wrote:
> > @@ -318,6 +318,65 @@ int kdbgetintenv(const char *match, int *value)
> > }
> >
> > /*
> > + * kdb_setenv() - Alter an existing environment variable or create a new one.
> > + * @var: Name of the variable
> > + * @val: Value of the variable
> > + *
> > + * Return: Zero on success, a kdb diagnostic on failure.
> > + */
> > +static int kdb_setenv(const char *var, const char *val)
> > +{
> > + int i;
> > + char *ep;
> > + size_t varlen, vallen;
> > +
> > + varlen = strlen(var);
> > + vallen = strlen(val);
> > + ep = kdballocenv(varlen + vallen + 2);
> > + if (ep == (char *)0)
> > + return KDB_ENVBUFFULL;
> > +
> > + sprintf(ep, "%s=%s", var, val);
> > +
> > + ep[varlen+vallen+1] = '\0';
>
> What is this line for? It looks pointless to me.
>

Yeah, it looks redundant to me as well.

> I know it's copied from the original code but it doesn't look like the
> sort of code you should want your name to appear next to in a git blame
> ;-) .
>

Sure, let me get rid of it in v3.

-Sumit

>
> Daniel.

\
 
 \ /
  Last update: 2021-02-08 08:59    [W:0.110 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site