lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] KVM: selftests: Keep track of memslots more efficiently
On Mon, Feb 08, 2021 at 11:16:41AM +0100, Andrew Jones wrote:
> > diff --git a/tools/testing/selftests/kvm/lib/rbtree.c b/tools/testing/selftests/kvm/lib/rbtree.c
> > new file mode 100644
> > index 000000000000..a703f0194ea3
> > --- /dev/null
> > +++ b/tools/testing/selftests/kvm/lib/rbtree.c
> > @@ -0,0 +1 @@
> > +#include "../../../../lib/rbtree.c"
> >
>
> We shouldn't dip into kernel code like this. We can use tools/lib/rbtree.c
> though.
>
> Besides the rbtree.c thing,

Oops, sorry, just realized the first '..' applies to kvm's lib subdir.
So this is already using tools/lib/rbtree.c

Thanks,
drew

>
> Reviewed-by: Andrew Jones <drjones@redhat.com>

\
 
 \ /
  Last update: 2021-02-08 11:36    [W:0.098 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site