[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel
Hi Zhengqiao,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 61556703b610a104de324e4f061dc6cf7b218b46
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Zhengqiao-Xia/drm-panel-Add-inx-Himax8279d-MIPI-DSI-LCD-panel/20210209-071837
git checkout 40cb37f54329ed37a56856e1122f8f5ba9c7a7d8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

drivers/gpu/drm/panel/panel-innolux-himax8279d.c:373:3: error: 'const struct drm_display_mode' has no member named 'vrefresh'
373 | .vrefresh = 60,
| ^~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_get_modes':
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:396:43: error: 'struct drm_panel' has no member named 'connector'; did you mean 'connector_type'?
396 | struct drm_connector *connector = panel->connector;
| ^~~~~~~~~
| connector_type
In file included from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/of_device.h:5,
from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:11:
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:401:31: error: 'const struct drm_display_mode' has no member named 'vrefresh'
401 | m->hdisplay, m->vdisplay, m->vrefresh);
| ^~
include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c: At top level:
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:3: error: 'const struct drm_panel_funcs' has no member named 'unprepare_power'
418 | .unprepare_power = inx_panel_unprepare_power,
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
418 | .unprepare_power = inx_panel_unprepare_power,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: note: (near initialization for 'inx_panel_funcs')
>> drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: warning: excess elements in struct initializer
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: note: (near initialization for 'inx_panel_funcs')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:3: error: 'const struct drm_panel_funcs' has no member named 'prepare_power'
420 | .prepare_power = inx_panel_prepare_power,
| ^~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
420 | .prepare_power = inx_panel_prepare_power,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: note: (near initialization for 'inx_panel_funcs')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types]
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: note: (near initialization for 'inx_panel_funcs.get_modes')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types]
422 | .get_modes = inx_panel_get_modes,
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: warning: initialized field overwritten [-Woverride-init]
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_add':
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:451:2: error: too few arguments to function 'drm_panel_init'
451 | drm_panel_init(&inx->base);
| ^~~~~~~~~~~~~~
In file included from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:16:
include/drm/drm_panel.h:176:6: note: declared here
176 | void drm_panel_init(struct drm_panel *panel, struct device *dev,
| ^~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:453:19: error: 'struct drm_panel' has no member named 'orientation'
453 | &inx->base.orientation);
| ^
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:464:9: error: void value not ignored as it ought to be
464 | return drm_panel_add(&inx->base);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:465:1: error: control reaches end of non-void function [-Werror=return-type]
465 | }
| ^
cc1: some warnings being treated as errors

vim +418 drivers/gpu/drm/panel/panel-innolux-himax8279d.c

416 static const struct drm_panel_funcs inx_panel_funcs = {
417 .unprepare = inx_panel_unprepare,
> 418 .unprepare_power = inx_panel_unprepare_power,
419 .prepare = inx_panel_prepare,
420 .prepare_power = inx_panel_prepare_power,
421 .enable = inx_panel_enable,
422 .get_modes = inx_panel_get_modes,
423 };

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2021-02-09 04:31    [W:0.061 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site