| Date | Tue, 09 Feb 2021 11:19:29 +1000 | From | Nicholas Piggin <> | Subject | Re: [PATCH v5 07/22] powerpc/irq: Add stub irq_soft_mask_return() for PPC32 |
| |
Excerpts from Christophe Leroy's message of February 9, 2021 1:10 am: > To allow building syscall_64.c smoothly on PPC32, add stub version > of irq_soft_mask_return(). > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Same kind of comment as the other soft mask stuff. Again not a big deal but there might be a way to improve it. For example make a debug_syscall_entry(regs) function that ppc64 could put the soft mask checks into.
No big deal, if you don't make any changes now I might see about doing something like that after your series goes in.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> --- > arch/powerpc/include/asm/hw_irq.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h > index 4739f61e632c..56a98936a6a9 100644 > --- a/arch/powerpc/include/asm/hw_irq.h > +++ b/arch/powerpc/include/asm/hw_irq.h > @@ -330,6 +330,11 @@ static inline void irq_soft_mask_regs_set_state(struct pt_regs *regs, unsigned l > } > #else /* CONFIG_PPC64 */ > > +static inline notrace unsigned long irq_soft_mask_return(void) > +{ > + return 0; > +} > + > static inline unsigned long arch_local_save_flags(void) > { > return mfmsr(); > -- > 2.25.0 > >
|