lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: rtl8723bs: remove braces from two single line if blocks
    Date
    Remove braces from both occurences of single line if blocks in
    include/rtw_mlme.h, fixes two checkpatch warnings, thus clearing
    this type of warning from this file.

    Also swaps two if statement comparisons around, so the variable is on
    the left in each one. This fixes two warnings also.

    Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
    ---
    drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
    index ea0dd156051e..d8655cb619a1 100644
    --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
    +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
    @@ -524,18 +524,16 @@ static inline void set_fwstate(struct mlme_priv *pmlmepriv, sint state)
    {
    pmlmepriv->fw_state |= state;
    /* FOR HW integration */
    - if (_FW_UNDER_SURVEY == state) {
    + if (state == _FW_UNDER_SURVEY)
    pmlmepriv->bScanInProcess = true;
    - }
    }

    static inline void _clr_fwstate_(struct mlme_priv *pmlmepriv, sint state)
    {
    pmlmepriv->fw_state &= ~state;
    /* FOR HW integration */
    - if (_FW_UNDER_SURVEY == state) {
    + if (state == _FW_UNDER_SURVEY)
    pmlmepriv->bScanInProcess = false;
    - }
    }

    /*
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-02-09 01:13    [W:21.885 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site