lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH]: checkpatch: Fixed styling issue
From
Date
On 2/8/21 11:51 AM, Mukul Mehar wrote:

More comments (probably duplicates):

a. The "checkpatch:" in the subject says that you are making a patch
to the "checkpatch" script. You are not doing that. The subject should
be more like: "staging: most: fix a style issue in sound.c" e.g.

b. This comment:
This is my first patch.

should not be in the comment message. If included at all, it should be
after the "---" line, like so:

---
This is my first patch.

<then the diffstat>.


thanks.
--
~Randy

\
 
 \ /
  Last update: 2021-02-08 22:48    [W:0.158 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site