Messages in this thread | | | Subject | Re: [PATCH v19 06/25] x86/cet: Add control-protection fault handler | From | "Yu, Yu-cheng" <> | Date | Mon, 8 Feb 2021 12:11:32 -0800 |
| |
On 2/8/2021 11:48 AM, Borislav Petkov wrote: > On Mon, Feb 08, 2021 at 11:23:18AM -0800, Yu, Yu-cheng wrote: >> exc_general_protection() and do_trap() both call show_signal(), which >> then calls printk_ratelimit(). > > You could've done some git archeology and could've found > > abd4f7505baf ("x86: i386-show-unhandled-signals-v3") > > which explains why that ratelimiting is needed. > >> For example, if a shell script, in a loop re-starts an app when it >> exits, and the app is causing control-protection fault. The log >> messages should be rate limited. > > I think you should be able to get where I'm going with this, by now: > please put a comment over the ratelimiting to explain why it is there, > just like the above commit explains.
I will add that.
> > Thx. >
| |