lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 09/14] riscv: virt_addr_valid must check the address belongs to linear mapping
    Date
    From: Alexandre Ghiti <alex@ghiti.fr>

    [ Upstream commit 2ab543823322b564f205cb15d0f0302803c87d11 ]

    virt_addr_valid macro checks that a virtual address is valid, ie that
    the address belongs to the linear mapping and that the corresponding
    physical page exists.

    Add the missing check that ensures the virtual address belongs to the
    linear mapping, otherwise __virt_to_phys, when compiled with
    CONFIG_DEBUG_VIRTUAL enabled, raises a WARN that is interpreted as a
    kernel bug by syzbot.

    Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
    Reviewed-by: Atish Patra <atish.patra@wdc.com>
    Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/riscv/include/asm/page.h | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
    index 06cfbb3aacbb0..abc147aeff8b0 100644
    --- a/arch/riscv/include/asm/page.h
    +++ b/arch/riscv/include/asm/page.h
    @@ -115,7 +115,10 @@ extern unsigned long min_low_pfn;

    #endif /* __ASSEMBLY__ */

    -#define virt_addr_valid(vaddr) (pfn_valid(virt_to_pfn(vaddr)))
    +#define virt_addr_valid(vaddr) ({ \
    + unsigned long _addr = (unsigned long)vaddr; \
    + (unsigned long)(_addr) >= PAGE_OFFSET && pfn_valid(virt_to_pfn(_addr)); \
    +})

    #define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | \
    VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-02-08 20:39    [W:6.528 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site