lkml.org 
[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[net-next PATCH v5 12/15] net/fsl: Use fwnode_mdiobus_register()
    Date
    fwnode_mdiobus_register() internally takes care of both DT
    and ACPI cases to register mdiobus. Replace existing
    of_mdiobus_register() with fwnode_mdiobus_register().

    Note: For both ACPI and DT cases, endianness of MDIO controller
    need to be specified using "little-endian" property.

    Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
    ---

    Changes in v5: None
    Changes in v4:
    - Cleanup xgmac_mdio_probe()

    Changes in v3:
    - Avoid unnecessary line removal
    - Remove unused inclusion of acpi.h

    Changes in v2: None

    drivers/net/ethernet/freescale/xgmac_mdio.c | 11 +++++++----
    1 file changed, 7 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
    index bfa2826c5545..dca5305e7185 100644
    --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
    +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
    @@ -2,6 +2,7 @@
    * QorIQ 10G MDIO Controller
    *
    * Copyright 2012 Freescale Semiconductor, Inc.
    + * Copyright 2021 NXP
    *
    * Authors: Andy Fleming <afleming@freescale.com>
    * Timur Tabi <timur@freescale.com>
    @@ -243,10 +244,9 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum)

    static int xgmac_mdio_probe(struct platform_device *pdev)
    {
    - struct device_node *np = pdev->dev.of_node;
    - struct mii_bus *bus;
    - struct resource *res;
    struct mdio_fsl_priv *priv;
    + struct resource *res;
    + struct mii_bus *bus;
    int ret;

    /* In DPAA-1, MDIO is one of the many FMan sub-devices. The FMan
    @@ -279,13 +279,16 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
    goto err_ioremap;
    }

    + /* For both ACPI and DT cases, endianness of MDIO controller
    + * needs to be specified using "little-endian" property.
    + */
    priv->is_little_endian = device_property_read_bool(&pdev->dev,
    "little-endian");

    priv->has_a011043 = device_property_read_bool(&pdev->dev,
    "fsl,erratum-a011043");

    - ret = of_mdiobus_register(bus, np);
    + ret = fwnode_mdiobus_register(bus, pdev->dev.fwnode);
    if (ret) {
    dev_err(&pdev->dev, "cannot register MDIO bus\n");
    goto err_registration;
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-02-08 17:55    [W:4.942 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site