lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH for-next 19/32] scsi: mvumi: Replace spin_lock_irqsave with spin_lock in hard IRQ
Date
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/scsi/mvumi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 71b6a1f..b36164c 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -1790,11 +1790,10 @@ static void mvumi_handle_clob(struct mvumi_hba *mhba)
static irqreturn_t mvumi_isr_handler(int irq, void *devp)
{
struct mvumi_hba *mhba = (struct mvumi_hba *) devp;
- unsigned long flags;

- spin_lock_irqsave(mhba->shost->host_lock, flags);
+ spin_lock(mhba->shost->host_lock);
if (unlikely(mhba->instancet->clear_intr(mhba) || !mhba->global_isr)) {
- spin_unlock_irqrestore(mhba->shost->host_lock, flags);
+ spin_unlock(mhba->shost->host_lock);
return IRQ_NONE;
}

@@ -1815,7 +1814,7 @@ static irqreturn_t mvumi_isr_handler(int irq, void *devp)
mhba->isr_status = 0;
if (mhba->fw_state == FW_STATE_STARTED)
mvumi_handle_clob(mhba);
- spin_unlock_irqrestore(mhba->shost->host_lock, flags);
+ spin_unlock(mhba->shost->host_lock);
return IRQ_HANDLED;
}

--
2.8.1
\
 
 \ /
  Last update: 2021-02-07 12:53    [W:0.198 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site