lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH for-next 26/32] scsi: qlogicfas408: Replace spin_lock_irqsave with spin_lock in hard IRQ
    Date
    It is redundant to do irqsave and irqrestore in hardIRQ context, where
    it has been in a irq-disabled context.

    Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
    ---
    drivers/scsi/qlogicfas408.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c
    index 136681a..2a70902 100644
    --- a/drivers/scsi/qlogicfas408.c
    +++ b/drivers/scsi/qlogicfas408.c
    @@ -426,12 +426,11 @@ static void ql_ihandl(void *dev_id)

    irqreturn_t qlogicfas408_ihandl(int irq, void *dev_id)
    {
    - unsigned long flags;
    struct Scsi_Host *host = dev_id;

    - spin_lock_irqsave(host->host_lock, flags);
    + spin_lock(host->host_lock);
    ql_ihandl(dev_id);
    - spin_unlock_irqrestore(host->host_lock, flags);
    + spin_unlock(host->host_lock);
    return IRQ_HANDLED;
    }

    --
    2.8.1
    \
     
     \ /
      Last update: 2021-02-07 12:47    [W:17.562 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site