lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH for-next 24/32] scsi: pmcraid: Replace spin_lock_irqsave with spin_lock in hard IRQ
Date
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/scsi/pmcraid.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 834556e..5967284 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4145,7 +4145,6 @@ static irqreturn_t pmcraid_isr_msix(int irq, void *dev_id)
{
struct pmcraid_isr_param *hrrq_vector;
struct pmcraid_instance *pinstance;
- unsigned long lock_flags;
u32 intrs_val;
int hrrq_id;

@@ -4170,12 +4169,9 @@ static irqreturn_t pmcraid_isr_msix(int irq, void *dev_id)

pmcraid_err("ISR: error interrupts: %x \
initiating reset\n", intrs_val);
- spin_lock_irqsave(pinstance->host->host_lock,
- lock_flags);
+ spin_lock(pinstance->host->host_lock);
pmcraid_initiate_reset(pinstance);
- spin_unlock_irqrestore(
- pinstance->host->host_lock,
- lock_flags);
+ spin_unlock(pinstance->host->host_lock);
}
/* If interrupt was as part of the ioa initialization,
* clear it. Delete the timer and wakeup the
--
2.8.1
\
 
 \ /
  Last update: 2021-02-07 12:46    [W:0.255 / U:1.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site