lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 2/4] soc: qcom: Add SoC sleep stats driver
Hi Maulik,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on arm64/for-next/core linux/master linus/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Maulik-Shah/Introduce-SoC-sleep-stats-driver/20210204-223344
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: h8300-randconfig-r013-20210207 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/60e8c659b52a5c1ac2b1a91d02df00ddecdccba8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Maulik-Shah/Introduce-SoC-sleep-stats-driver/20210204-223344
git checkout 60e8c659b52a5c1ac2b1a91d02df00ddecdccba8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/soc/qcom/soc_sleep_stats.c: In function 'soc_sleep_stats_show':
>> drivers/soc/qcom/soc_sleep_stats.c:113:25: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
113 | stat.last_entered_at = readq(reg + LAST_ENTERED_AT_ADDR);
| ^~~~~
| readl
cc1: some warnings being treated as errors


vim +113 drivers/soc/qcom/soc_sleep_stats.c

105
106 static int soc_sleep_stats_show(struct seq_file *s, void *d)
107 {
108 struct stats_prv_data *prv_data = s->private;
109 void __iomem *reg = prv_data->reg;
110 struct sleep_stats stat;
111
112 stat.count = readl(reg + COUNT_ADDR);
> 113 stat.last_entered_at = readq(reg + LAST_ENTERED_AT_ADDR);
114 stat.last_exited_at = readq(reg + LAST_EXITED_AT_ADDR);
115 stat.accumulated = readq(reg + ACCUMULATED_ADDR);
116
117 print_sleep_stats(s, &stat);
118
119 if (prv_data->appended_stats_avail) {
120 struct appended_stats app_stat;
121
122 app_stat.client_votes = readl(reg + CLIENT_VOTES_ADDR);
123 seq_printf(s, "Client_votes = %#x\n", app_stat.client_votes);
124 }
125
126 return 0;
127 }
128

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-02-07 11:27    [W:0.188 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site