Messages in this thread | | | Subject | Re: [PATCH v4 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver | From | Stephen Boyd <> | Date | Sat, 06 Feb 2021 19:21:39 -0800 |
| |
Quoting Jonathan Cameron (2021-02-06 08:17:11) > On Tue, 2 Feb 2021 10:44:34 -0800 > Stephen Boyd <swboyd@chromium.org> wrote: > > > +static struct platform_driver cros_ec_mkbp_proximity_driver = { > > + .driver = { > > + .name = "cros-ec-mkbp-proximity", > > + .of_match_table = of_match_ptr(cros_ec_mkbp_proximity_of_match), > I'm going to assume we know no one is going to use this with > ACPI via PRP0001 given presumably the firmware on these devices > is tightly controlled.
Correct.
> > However, we should should still drop the of_match_ptr > as it will lead to an unused warning for cros_ec_mkbp_proximity_of_match > if anyone builds this without CONFIG_OF + it sets a general bad > precedence that I'd rather wasn't around for people to copy. > Note that in general we are slowly ripping these out of IIO but > probably lots still there. > > If this is all that is needed in this version I'll just do it > whilst applying unless anyone shouts. >
Agreed. Thanks for fixing that last little bit.
| |