[lkml]   [2021]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] staging: emxx_udc: Fix incorrectly defined global
    The global gpio_desc pointer and int were defined in the header,
    instead put the definitions in the translation unit and add an extern
    declaration for consumers of the header (currently only one, which is
    perhaps why the linker didn't complain about symbol collisions).

    This fixes sparse related warnings for this driver:
    drivers/staging/emxx_udc/emxx_udc.c: note: in included file:
    drivers/staging/emxx_udc/emxx_udc.h:23:18: warning: symbol 'vbus_gpio' was not declared. Should it be static?
    drivers/staging/emxx_udc/emxx_udc.h:24:5: warning: symbol 'vbus_irq' was not declared. Should it be static?

    Signed-off-by: Kumar Kartikeya Dwivedi <>
    drivers/staging/emxx_udc/emxx_udc.c | 3 +++
    drivers/staging/emxx_udc/emxx_udc.h | 4 ++--
    2 files changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
    index a30b4f5b1..6983c3e31 100644
    --- a/drivers/staging/emxx_udc/emxx_udc.c
    +++ b/drivers/staging/emxx_udc/emxx_udc.c
    @@ -34,6 +34,9 @@
    #define DRIVER_DESC "EMXX UDC driver"
    #define DMA_ADDR_INVALID (~(dma_addr_t)0)

    +struct gpio_desc *vbus_gpio;
    +int vbus_irq;
    static const char driver_name[] = "emxx_udc";
    static const char driver_desc[] = DRIVER_DESC;

    diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
    index bca614d69..b3c4ccbe5 100644
    --- a/drivers/staging/emxx_udc/emxx_udc.h
    +++ b/drivers/staging/emxx_udc/emxx_udc.h
    @@ -20,8 +20,8 @@
    /* below hacked up for staging integration */
    #define GPIO_VBUS 0 /* GPIO_P153 on KZM9D */
    #define INT_VBUS 0 /* IRQ for GPIO_P153 */
    -struct gpio_desc *vbus_gpio;
    -int vbus_irq;
    +extern struct gpio_desc *vbus_gpio;
    +extern int vbus_irq;

    /*------------ Board dependence(Wait) */

     \ /
      Last update: 2021-02-07 01:04    [W:7.185 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site