lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh
From
Date
On 2/5/21 12:55 AM, Rong Chen wrote:
> Commit c2aa8afc36fa has renamed run_vmtests in Makefile,
> but the file still uses the old name.
>
> The kernel test robot reported the following issue:
>
> # selftests: vm: run_vmtests.sh
> # Warning: file run_vmtests.sh is missing!
> not ok 1 selftests: vm: run_vmtests.sh
>

I don't know exactly what is going on here, but there was originally a mistake
on my part in renaming run_vmtests to run_vmtests.sh (I was trying to set
the executable bit, which is not always supported by the patch flow), and that
caused some churn in Andrews's tree. And so maybe that rename got lost/dropped
along the way.

> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: c2aa8afc36fa (selftests/vm: rename run_vmtests --> run_vmtests.sh)
> Signed-off-by: Rong Chen <rong.a.chen@intel.com>
> ---
> tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} (100%)
>
> diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests.sh
> similarity index 100%
> rename from tools/testing/selftests/vm/run_vmtests
> rename to tools/testing/selftests/vm/run_vmtests.sh
>

So I guess this is OK, given that I see "run_vmtests" in both -next
and main.

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
--
John Hubbard
NVIDIA

\
 
 \ /
  Last update: 2021-02-05 21:10    [W:0.055 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site