Messages in this thread |  | | From | Prashant Malani <> | Date | Fri, 5 Feb 2021 12:06:41 -0800 | Subject | Re: [PATCH 2/2] platform/chrome: cros_ec_types: Support disconnect events without partners |
| |
On Fri, Feb 5, 2021 at 12:05 PM Prashant Malani <pmalani@chromium.org> wrote: > > Hi Raj, > > On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani <rajmohan.mani@intel.com> wrote: > > > > There are certain scenarios, where a disconnect event might > > occur on a Type-C port with no port partners. This is required > > to enable communication to Burnside Bridge USB4 retimers. > > > > Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com> > minor commit message nit (apologies for not spotting this earlier): > > This patch alone doesn't add support for the "without partners" part > (that comes in the next patch). > This one purely adds support for disconnect events. So might be good > to update the commit message if possible. Sorry, I just noticed that I interpreted the ordering of the patches incorrectly, so this commit message is fine as is and I retract my nit.
> But otherwise LGTM, so: > > Reviewed-by: Prashant Malani <pmalani@chromium.org>
|  |