Messages in this thread |  | | Subject | Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT | From | Jacek Anaszewski <> | Date | Fri, 5 Feb 2021 19:37:28 +0100 |
| |
Hi Pavel,
On 2/5/21 11:23 AM, Pavel Machek wrote: > Hi! > >>>> patternProperties: >>>> "(^led-[0-9a-f]$|led)": >>>> @@ -99,6 +104,7 @@ examples: >>>> reg = <0x1>; >>>> color = <LED_COLOR_ID_RGB>; >>>> function = LED_FUNCTION_CHARGING; >>>> + default-intensity = <100 0 0>;
How will you know which array position is for which child LED? I presume DT child nodes are not guaranteed to be parsed in the order of declaration?
>>>> >>>> led-0 { >>>> color = <LED_COLOR_ID_RED>; >>> >>> Should this go to leds-class-multicolor.yaml ? >> >> I think then all drivers should support it, but I cannot change all drivers. >> So I would only leave it in there. > > It really should be in common binding, and no, that does not mean you > need to change all the drivers. > > Plus there's at most two of them at the moment. > > Best regards, > Pavel >
-- Best regards, Jacek Anaszewski
|  |