lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] checkpatch: Don't warn about colon termination in linker scripts
From
Date
On Thu, 2021-02-04 at 16:32 +0000, Chris Down wrote:
> This check erroneously flags cases like the one in my recent printk
> enumeration patch[0], where the spaces are syntactic, and `section:' vs.
> `section :' is syntactically important:
>
>     ERROR: space prohibited before that ':' (ctx:WxW)
>     #258: FILE: include/asm-generic/vmlinux.lds.h:314:
>     + .printk_fmts : AT(ADDR(.printk_fmts) - LOAD_OFFSET) {
>
> 0: https://lore.kernel.org/patchwork/patch/1375749/

Remember to cc the checkpatch maintainers.

> Signed-off-by: Chris Down <chris@chrisdown.name>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4f8494527139..3bcffc5574ae 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5046,7 +5046,7 @@ sub process {
>   # A colon needs no spaces before when it is
>   # terminating a case value or a label.
>   } elsif ($opv eq ':C' || $opv eq ':L') {
> - if ($ctx =~ /Wx./) {
> + if ($ctx =~ /Wx./ and $realfile !~ m@.*\.lds\.h$@) {
>   if (ERROR("SPACING",
>   "space prohibited before that '$op' $at\n" . $hereptr)) {
>   $good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);


\
 
 \ /
  Last update: 2021-02-06 05:46    [W:0.052 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site