[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS
Song Yoong Siang <> writes:

> From: Mohammad Athari Bin Ismail <>
> When disable CBS, mode_to_use parameter is not updated even the operation
> mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore,
> when tc_setup_cbs() function is called to re-enable CBS, the operation
> mode of Tx Queue remains at DCB, which causing CBS fails to work.
> This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB
> after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode()
> callback function.
> Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> Suggested-by: Gomes, Vinicius <>

Just a nitpick/formality, I would prefer if you used:

Suggested-by: Vinicius Costa Gomes <>

> Signed-off-by: Mohammad Athari Bin Ismail <>
> Signed-off-by: Song, Yoong Siang <>

Patch looks good.

Acked-by: Vinicius Costa Gomes <>


 \ /
  Last update: 2021-02-06 05:10    [W:0.061 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site