Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 6 Feb 2021 09:52:28 +0900 | Subject | Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag |
| |
On Fri, Feb 5, 2021 at 6:54 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, Feb 05, 2021 at 05:44:15PM +0800, Yicong Yang wrote: > > From: Junhao He <hejunhao2@hisilicon.com> > > > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > > settings from Kconfig when traversing subdirectories. > > Again, explain _why_. > > Please read the section entitled "The canonical patch format" in the > kernel file, Documentation/SubmittingPatches for what a proper changelog > should look like. > > thanks, > > greg k-h
I think this is a good clean-up, assuming CONFIG_COMEDI_DEBUG intends to give the DEBUG flag to all source files under drivers/staging/comedi/.
-- Best Regards Masahiro Yamada
| |