Messages in this thread | | | From | Brendan Higgins <> | Date | Fri, 5 Feb 2021 14:28:16 -0800 | Subject | Re: [PATCH] kunit: tool: simplify kconfig is_subset_of() logic |
| |
On Tue, Dec 8, 2020 at 3:21 PM Daniel Latypov <dlatypov@google.com> wrote: > > Don't use an O(nm) algorithm* and make it more readable by using a dict. > > *Most obviously, it does a nested for-loop over the entire other config. > A bit more subtle, it calls .entries(), which constructs a set from the > list for _every_ outer iteration. > > Signed-off-by: Daniel Latypov <dlatypov@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com> Acked-by: Brendan Higgins <brendanhiggins@google.com>
| |