lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/mlock: stop counting mlocked pages when none vma is found
From
Date
On 04.02.21 12:07, Miaohe Lin wrote:
> There will be no vma satisfies addr < vm_end when find_vma() returns NULL.
> Thus it's meaningless to traverse the vma list below because we can't find
> any vma to count mlocked pages. Stop counting mlocked pages in this case to
> save some vma list traversal cycles.

I think this is correct. We will have addr >= vm_end for any VMA, so
there are no applicable VMAs.

Reviewed-by: David Hildenbrand <david@redhat.com>

>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 73960bb3464d..f8f8cc32d03d 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -622,7 +622,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm,
>
> vma = find_vma(mm, start);
> if (vma == NULL)
> - vma = mm->mmap;
> + return 0;
>
> for (; vma ; vma = vma->vm_next) {
> if (start >= vma->vm_end)
>


--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-02-05 09:17    [W:0.071 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site