[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 23/28] KVM: x86/mmu: Allow parallel page faults for the TDP MMU
On Wed, Feb 03, 2021, Paolo Bonzini wrote:
> On 03/02/21 18:46, Ben Gardon wrote:
> > enum kvm_mmu_lock_mode lock_mode =
> > get_mmu_lock_mode_for_root(vcpu->kvm, vcpu->arch.mmu->root_hpa);
> > ....
> > kvm_mmu_lock_for_mode(lock_mode);
> >
> > Not sure if either of those are actually clearer, but the latter
> > trends in the direction the RCF took, having an enum to capture
> > read/write and whether or not yo yield in a lock mode parameter.
> Could be a possibility. Also:
> enum kvm_mmu_lock_mode lock_mode =
> kvm_mmu_lock_for_root(vcpu->kvm, vcpu->arch.mmu->root_hpa);
> kvm_mmu_unlock(vcpu->kvm, lock_mode);
> Anyway it can be done on top.

Maybe go with a literal name, unless we expect additional usage? E.g.
kvm_mmu_(un)lock_for_page_fault() isn't terrible.

I'm not a fan of the kvm_mmu_lock_for_root() variants. "for_root" doesn't have
an obvious connection to the page fault handler or to the read/shared mode of
the TDP. But, the name is also specific enough to pique my curiosity and make
me wonder what's it's doing.

 \ /
  Last update: 2021-02-06 03:54    [W:0.114 / U:3.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site