lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectAW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT
Date
Hello Pavel, hello Dan,

> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-
> lp50xx.yaml
> > index c192b5feadc7..2bc25b2fc94d 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > @@ -65,6 +65,11 @@ patternProperties:
> > This property denotes the LED module number(s) that is used on the
> > for the child node. The LED modules can either be used stand alone
> > or grouped into a module bank.
> > + default-intensity:
> > + minItems: 1
> > + maxItems: 3
> > + description:
>
> Do we need more than three for RGBW and similar?

AFAIK the lp50xx supports only RGB. So I would go for that.


> > patternProperties:
> > "(^led-[0-9a-f]$|led)":
> > @@ -99,6 +104,7 @@ examples:
> > reg = <0x1>;
> > color = <LED_COLOR_ID_RGB>;
> > function = LED_FUNCTION_CHARGING;
> > + default-intensity = <100 0 0>;
> >
> > led-0 {
> > color = <LED_COLOR_ID_RED>;
>
> Should this go to leds-class-multicolor.yaml ?

I think then all drivers should support it, but I cannot change all drivers.
So I would only leave it in there.


> Can you make example
> <255 120 0> or something like that, so make it clear it is not
> percent?

Sure

Best Regards,

Sven



\
 
 \ /
  Last update: 2021-02-06 01:55    [W:0.073 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site