lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 03/22] media: camss: Replace trace_printk() with dev_dbg()
    Date
    trace_printk() should not be used in production code,
    since extra memory is used for special buffers whenever
    trace_puts() is used.

    Replace it with dev_dbg() which provides all of the desired
    debugging functionality.

    Signed-off-by: Robert Foss <robert.foss@linaro.org>
    Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
    ---

    Changes since v3:
    - Nicolas: Create this patch


    drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++--
    drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++--
    2 files changed, 6 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
    index a1b56b89130d..85b9bcbc7321 100644
    --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
    +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
    @@ -12,6 +12,7 @@
    #include <linux/io.h>
    #include <linux/iopoll.h>

    +#include "camss.h"
    #include "camss-vfe.h"

    #define VFE_0_HW_VERSION 0x000
    @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)

    vfe->ops->isr_read(vfe, &value0, &value1);

    - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
    - value0, value1);
    + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
    + value0, value1);

    if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
    vfe->isr_ops.reset_ack(vfe);
    diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
    index 84c33b8f9fe3..f7e00a2de393 100644
    --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
    +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
    @@ -12,6 +12,7 @@
    #include <linux/io.h>
    #include <linux/iopoll.h>

    +#include "camss.h"
    #include "camss-vfe.h"

    #define VFE_0_HW_VERSION 0x000
    @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)

    vfe->ops->isr_read(vfe, &value0, &value1);

    - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
    - value0, value1);
    + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
    + value0, value1);

    if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
    vfe->isr_ops.reset_ack(vfe);
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-02-06 01:43    [W:4.071 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site