lkml.org 
[lkml]   [2021]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/hugetlb: use helper huge_page_size() to simplify the hugetlb_vm_op_pagesize()
From
Date
On 05.02.21 10:22, Miaohe Lin wrote:
> We can use helper huge_page_size() to get the size of the pages allocated
> when backing a VMA directly to make the code more simplified.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/hugetlb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 18628f8dbfb0..3eea2a34d9f5 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3647,9 +3647,7 @@ static int hugetlb_vm_op_split(struct vm_area_struct *vma, unsigned long addr)
>
> static unsigned long hugetlb_vm_op_pagesize(struct vm_area_struct *vma)
> {
> - struct hstate *hstate = hstate_vma(vma);
> -
> - return 1UL << huge_page_shift(hstate);
> + return huge_page_size(hstate_vma(vma));
> }

Maybe it makes sense to squash all of these individual patches you send
that do the same things/perform the same cleanups. Shouldn't be to hard
to identify all these cases using simple "git grep".

Makes life of reviewers and maintainers easier ...


--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-02-06 00:08    [W:0.062 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site