lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
Date


On 04.02.2021 18:01, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
\
 
 \ /
  Last update: 2021-02-04 19:21    [W:0.089 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site