lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] clocksource/drivers/hyper-v: Handle sched_clock differences inline
On Thu, Feb 04, 2021 at 04:28:38PM +0000, Michael Kelley wrote:
> From: Wei Liu <wei.liu@kernel.org> Sent: Monday, February 1, 2021 10:55 AM
> >
> > On Wed, Jan 27, 2021 at 12:23:43PM -0800, Michael Kelley wrote:
> > [...]
> > > +/*
> > > + * Reference to pv_ops must be inline so objtool
> > > + * detection of noinstr violations can work correctly.
> > > + */
> > > +static __always_inline void hv_setup_sched_clock(void *sched_clock)
> >
> > sched_clock_register is not trivial. Having __always_inline here is
> > going to make the compiled object bloated.
> >
> > Given this is a static function, I don't think we need to specify any
> > inline keyword. The compiler should be able to determine whether this
> > function should be inlined all by itself.
> >
> > Wei.
>
> There was an explicit request from Peter Zijlstra and Thomas Gleixner
> to force it inline. See https://lore.kernel.org/patchwork/patch/1283635/ and
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/x86/include/asm/mshyperv.h?id=b9d8cf2eb3ceecdee3434b87763492aee9e28845

Oh. noinstr. I failed to notice the comment. Sorry for the noise.

Wei.

\
 
 \ /
  Last update: 2021-02-04 17:35    [W:0.082 / U:4.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site