lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] crypto: marvell - fix ethernet driver dependency
Date
From: Arnd Bergmann <arnd@arndb.de>

The OcteonTX2 CPT driver force-enables the OCTEONTX2_MBOX symbol,
which fails when network drivers are disabled globally

WARNING: unmet direct dependencies detected for OCTEONTX2_MBOX
Depends on [n]: NETDEVICES [=n] && ETHERNET [=n] && NET_VENDOR_MARVELL [=n]
Selected by [y]:
- CRYPTO_DEV_OCTEONTX2_CPT [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && (ARM64 [=y] || COMPILE_TEST [=y]) && PCI_MSI [=y] && 64BIT [=y] && CRYPTO_LIB_AES [=y]

The crypto driver actually fails to link without the ethernet side,
so this is a hard dependency. Change the 'select' into 'depends on'
to make it build reliably without warnings.

Fixes: 5e8ce8334734 ("crypto: marvell - add Marvell OcteonTX2 CPT PF driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/marvell/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/marvell/Kconfig b/drivers/crypto/marvell/Kconfig
index 2efbd79180ce..576d9e46fb88 100644
--- a/drivers/crypto/marvell/Kconfig
+++ b/drivers/crypto/marvell/Kconfig
@@ -39,9 +39,9 @@ config CRYPTO_DEV_OCTEONTX_CPT
config CRYPTO_DEV_OCTEONTX2_CPT
tristate "Marvell OcteonTX2 CPT driver"
depends on ARM64 || COMPILE_TEST
+ depends on OCTEONTX2_MBOX
depends on PCI_MSI && 64BIT
depends on CRYPTO_LIB_AES
- select OCTEONTX2_MBOX
select CRYPTO_DEV_MARVELL
select CRYPTO_SKCIPHER
select CRYPTO_HASH
--
2.29.2
\
 
 \ /
  Last update: 2021-02-04 16:45    [W:4.867 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site