lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] leds: lp50xx: add setting of default intensity from DT
On Thu 2021-02-04 14:38:03, Sven Schuchmann wrote:
> In order to use a multicolor-led together with a trigger
> the led needs to have an intensity set to see something.
> The trigger changes the brightness of the led but if there
> is no intensity we actually see nothing.
>
> This patch adds the ability to set the default intensity
> of each multi-led node so that it is turned on from DT.
> If no intensity is given the led will be initialized
> with full intensity.

> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>

Check your email headers, empty To: is strange.

> diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> index 79bc071c31fb..e8aa36c7e963 100644
> --- a/drivers/leds/leds-lp50xx.c
> +++ b/drivers/leds/leds-lp50xx.c
> @@ -504,6 +504,24 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
> num_colors++;
> }
>
> + if (fwnode_property_count_u32(child, "default-intensity")
> + == num_colors) {
> +
> + int j, def_int[LP50XX_LEDS_PER_MODULE];

No need for empty line?


> + ret = fwnode_property_read_u32_array(child,
> + "default-intensity", def_int, num_colors);
> + if (ret) {
> + dev_err(&priv->client->dev,
> + "Cannot read default-intensity: %d\n",
> + ret);
> + goto child_out;
> + }

Just ignore such error?

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-02-04 15:59    [W:2.115 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site