lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT
Hi!

> In order to use a multicolor-led together with a trigger
> the led needs to have an intensity set to see something.
> The trigger changes the brightness of the led but if there
> is no intensity we actually see nothing.
>
> This patch adds the ability to set the default intensity
> of each multi-led node so that it is turned on from DT.
> If no intensity is given the led will be initialized
> with full intensity.
>
> Part 1 updates the documentation.
> Part 2 removes an unused variable.
> Part 3 sets the initial intensity to full.
> Part 4 reads the default intensity from DT
>

> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index c192b5feadc7..2bc25b2fc94d 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -65,6 +65,11 @@ patternProperties:
> This property denotes the LED module number(s) that is used on the
> for the child node. The LED modules can either be used stand alone
> or grouped into a module bank.
> + default-intensity:
> + minItems: 1
> + maxItems: 3
> + description:

Do we need more than three for RGBW and similar?

> + The default intensity the multi-led gets initialised with.
>
> patternProperties:
> "(^led-[0-9a-f]$|led)":
> @@ -99,6 +104,7 @@ examples:
> reg = <0x1>;
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_CHARGING;
> + default-intensity = <100 0 0>;
>
> led-0 {
> color = <LED_COLOR_ID_RED>;

Should this go to leds-class-multicolor.yaml ? Can you make example
<255 120 0> or something like that, so make it clear it is not
percent?

Best regards,
Pavel

--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-02-04 15:55    [W:0.117 / U:1.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site