Messages in this thread | | | Subject | Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic | From | Tom Rix <> | Date | Thu, 4 Feb 2021 06:24:40 -0800 |
| |
On 2/3/21 3:06 PM, Russ Weight wrote: > > On 2/3/21 7:25 AM, Tom Rix wrote: >> ..snip.. >> >> On 2/2/21 3:06 PM, Russ Weight wrote: >>> diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h >>> index 576e94960086..e5020e2b1f3d 100644 >>> --- a/drivers/fpga/dfl-afu.h >>> +++ b/drivers/fpga/dfl-afu.h >>> @@ -80,7 +80,7 @@ struct dfl_afu { >>> }; >>> >>> /* hold pdata->lock when call __afu_port_enable/disable */ >>> -void __afu_port_enable(struct platform_device *pdev); >>> +int __afu_port_enable(struct platform_device *pdev); >>> int __afu_port_disable(struct platform_device *pdev); >>> >> Should the '__' prefix be removed from __afu_port* ? >> >> This would make the function names consistent with the other decls > The '__' prefix is used here to help highlight the fact that these functions go not manage > the locking themselves and must be called while holding the port mutex. There are additional > functions, such as__port_reset(), that are following this same convention. I think these > are OK as they are.
ok
Reviewed-by: Tom Rix <trix@redhat.com>
Tom
> > - Russ > >> Tom >> >>> void afu_mmio_region_init(struct dfl_feature_platform_data *pdata);
| |