lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits
From
Date
Hi!

>vreg_l14a_1p88: ldo14 {
>+ regulator-min-microvolt = <1800000>;
>+ regulator-max-microvolt = <1800000>;

Should probably be renamed to vreg_l14a_1p8 then.


>+ ports {
>+ port@1 {
>+ endpoint {
>+ remote-endpoint = <&tianma_nt36672a_in_0>;
>+ data-lanes = <0 1 2 3>;
>+ };
>+ };
>+ };

The endpoint has a label, you can simply use &dsi0_out {};.

>+ vddpos-supply = <&lab>;
>+ vddneg-supply = <&ibb>;

With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]),
as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage.



Konrad

[1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@somainline.org/
[2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53

\
 
 \ /
  Last update: 2021-02-04 15:20    [W:0.382 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site