lkml.org 
[lkml]   [2021]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")
    On Wed, 20 Jan 2021, Hans de Goede wrote:

    > The (shared) probing code of the arizona-i2c and arizona-spi modules
    > takes the following steps during init:
    >
    > 1. Call mfd_add_devices() for a set of early child-devices, this
    > includes the arizona_ldo1 device which provides one of the
    > core-regulators.
    >
    > 2. Bulk enable the core-regulators.
    >
    > 3. Read the device id.
    >
    > 4. Call mfd_add_devices() for the other child-devices.
    >
    > This sequence depends on 1. leading to not only the child-device
    > being created, but also the driver for the child-device binding
    > to it and registering its regulator.
    >
    > This requires the arizona_ldo1 driver to be loaded before the
    > shared probing code runs. Add a softdep for this to both modules to
    > ensure that this requirement is met.
    >
    > Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator")
    > in the wm8994 code, which has a similar init sequence.
    >
    > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    > ---
    > drivers/mfd/arizona-i2c.c | 1 +
    > drivers/mfd/arizona-spi.c | 1 +
    > 2 files changed, 2 insertions(+)

    Applied, thanks.

    --
    Lee Jones [李琼斯]
    Senior Technical Lead - Developer Services
    Linaro.org │ Open source software for Arm SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2021-02-04 15:05    [W:16.149 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site