Messages in this thread | | | Date | Thu, 4 Feb 2021 13:55:13 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v4 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() |
| |
On Wed, 20 Jan 2021, Hans de Goede wrote:
> Replace the custom arizona_of_get_type() function with the generic > device_get_match_data() helper. Besides being a nice cleanup this > also makes it easier to add support for binding to ACPI enumerated > devices. > > While at it also fix a possible NULL pointer deref of the id > argument to the probe functions (this could happen on e.g. manual > driver binding through sysfs). > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v2: > - New patch in v2 of this patchset > --- > drivers/mfd/arizona-core.c | 11 ----------- > drivers/mfd/arizona-i2c.c | 10 ++++++---- > drivers/mfd/arizona-spi.c | 10 ++++++---- > drivers/mfd/arizona.h | 9 --------- > 4 files changed, 12 insertions(+), 28 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |